Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource_to_telemetry_conversion config in prometheusremotewriteexp #3031

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Add resource_to_telemetry_conversion config in prometheusremotewriteexp #3031

merged 1 commit into from
Apr 30, 2021
+10 −0

Conversation

mxiamxia
Copy link
Member

Description:
Add exporterhelper.ResourceToTelemetrySettings support in prometheusremotewriteexporter config. It will allow both prometheusremotewriteexporter and ampprometheusremotewriteexporter be able to convert Resource attributes to Metric Labels for Prometheus metrics.

    prometheusremotewrite:
        resource_to_telemetry_conversion:
            enabled: true

Link to tracking Issue:
aws-observability/aws-otel-collector#472

Testing:
make all

@mxiamxia mxiamxia requested a review from a team April 26, 2021 23:02
@mxiamxia
Copy link
Member Author

@Aneurysm9 @alolita

@bogdandrutu
Copy link
Member

Please rebase to pick the latest correctness checks

@bogdandrutu
Copy link
Member

Ping @mxiamxia

@mxiamxia mxiamxia force-pushed the amp_resource_attrs branch from b3fd5f5 to edd3359 Compare April 29, 2021 22:51
@mxiamxia
Copy link
Member Author

Please rebase to pick the latest correctness checks

Yep. the new one picked it up. ty!

@mxiamxia mxiamxia force-pushed the amp_resource_attrs branch from edd3359 to 269e791 Compare April 29, 2021 23:47
@bogdandrutu bogdandrutu merged commit 232ce85 into open-telemetry:main Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxiamxia @bogdandrutu